Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

danken at redhat.com danken at redhat.com
Tue Mar 22 11:11:56 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: exception: Add exceptions for vdsm.define errors
......................................................................


exception: Add exceptions for vdsm.define errors

Add an exception class for each error in vdsm.define.

The long term goal is simplifying error handling, so code can raise
error in whatever layer the error happened, and single error handler
will generate the response using the error response() method.

As a temporary step, define.errCode is using the new exceptions to build
the response dict. When callers are updated to raise the new exceptions,
we can drop the errCode dict and the define module.

Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48871
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M lib/vdsm/define.py
M lib/vdsm/exception.py
M tests/responseTests.py
3 files changed, 385 insertions(+), 183 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list