Change in vdsm[master]: hooks:checkips: add checkips hook
danken at redhat.com
danken at redhat.com
Tue Mar 22 11:07:29 UTC 2016
Dan Kenigsberg has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
......................................................................
Patch Set 6: Code-Review-1
(3 comments)
much more minor issues
https://gerrit.ovirt.org/#/c/54102/6/vdsm_hooks/checkips/README
File vdsm_hooks/checkips/README:
Line 36: host does not connective
-> the host fails to ping
Line 37: host
the network's state to down. If the network is defined as "required", the host owuld become non-operational.
https://gerrit.ovirt.org/#/c/54102/6/vdsm_hooks/checkips/checkips
File vdsm_hooks/checkips/checkips:
Line 33: PING_TIMEOUT = 15
Line 34: PING_SAMPLE_TIME = 20
Line 35:
Line 36:
Line 37: def _is_ipv4_address(address):
dead code, please drop,
Line 38: try:
Line 39: socket.inet_pton(socket.AF_INET, address)
Line 40: except socket.error: # not a valid address
Line 41: return False
--
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list