Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm

fromani at redhat.com fromani at redhat.com
Fri Mar 18 14:16:03 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
......................................................................


Patch Set 12: Code-Review+2

(1 comment)

raising score after Martin (conditional) approval :)

https://gerrit.ovirt.org/#/c/53620/12/tests/deviceTests.py
File tests/deviceTests.py:

Line 550:             vmdevices.hostdevice.HostDevice.update_device_info(testvm,
        :                                                                device_conf)
> Idea for future patch: to really test the function, following flow should b
Added a trello card so we don't forget about this.


-- 
To view, visit https://gerrit.ovirt.org/53620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I789d7d2349fc24b48e52260de98fb3d66b168bf7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list