Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm

mpolednik at redhat.com mpolednik at redhat.com
Fri Mar 18 13:22:45 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
......................................................................


Patch Set 12: Code-Review+1

(1 comment)

My +1 is only valid if I get promise of the test being improved in future.

https://gerrit.ovirt.org/#/c/53620/12/tests/deviceTests.py
File tests/deviceTests.py:

Line 550:             vmdevices.hostdevice.HostDevice.update_device_info(testvm,
        :                                                                device_conf)
Idea for future patch: to really test the function, following flow should be executed:

1) define (fake) libvirt XML where the address is not present (source address needs to be present, generic device address does not) - this is what VDSM sends to libvirt
2) insert the address into XML (= play libvirt's role)
3) verify that the address is present in device object after updating the device info

to really test that the device detection works, XML must include multiple devices and test must verify that the addresses assigned to them are correct.


-- 
To view, visit https://gerrit.ovirt.org/53620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I789d7d2349fc24b48e52260de98fb3d66b168bf7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list