Change in vdsm[master]: tests: Use multiple context expressions

nsoffer at redhat.com nsoffer at redhat.com
Wed Mar 16 15:04:37 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: tests: Use multiple context expressions
......................................................................


tests: Use multiple context expressions

Since Python 2.7, multiple context expressions are supported in with
statement, eliminating the need for nesting or using the deprecated
nested() helper.

This patch simplify with usage the DirectFile tests.

See https://docs.python.org/2/reference/compound_stmts.html#the-with-statement

Change-Id: I84a41c2de29715fa253d0c9af9a8d257e79f36dd
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54676
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
---
M tests/fileUtilTests.py
1 file changed, 16 insertions(+), 19 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54676
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84a41c2de29715fa253d0c9af9a8d257e79f36dd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list