Change in vdsm[master]: tests: Use multiple context expressions

alitke at redhat.com alitke at redhat.com
Wed Mar 16 13:34:59 UTC 2016


Adam Litke has posted comments on this change.

Change subject: tests: Use multiple context expressions
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/54676/3/tests/fileUtilTests.py
File tests/fileUtilTests.py:

Line 70:         ullamcorper enim arcu class neque inceptos class. Ut, sagittis
Line 71:         torquent, commodo facilisi."""
Line 72:         with temporaryPath() as srcPath, fileUtils.open_ex(srcPath, "dw") as f:
Line 73:             f.write(data)
Line 74:             with fileUtils.open_ex(srcPath, "r") as f:
> intentionally left out?
It's a separate operation that has to happen after the f.write(...).
Line 75:                 self.assertEquals(f.read(len(data)), data)
Line 76: 
Line 77:     def testSmallWrites(self):
Line 78:         data = """


-- 
To view, visit https://gerrit.ovirt.org/54676
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a41c2de29715fa253d0c9af9a8d257e79f36dd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list