Change in vdsm[master]: repoplot: Add LVM commands graph

nsoffer at redhat.com nsoffer at redhat.com
Thu Mar 3 19:39:46 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: repoplot: Add LVM commands graph
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/54080/3/contrib/repoplot
File contrib/repoplot:

Line 110:         # --cpu-list 0-7 /usr/bin/sudo -n /usr/sbin/lvm vgck ...
Line 111:         #
Line 112:         # End:
Line 113:         # Thread-57::DEBUG::2016-02-17
Line 114:         # 19:26:33,933::lvm::286::Storage.Misc.excCmd::(cmd) SUCCESS: ...
> The Thread-XX should match in each case, correct?
Yes, I copied the wrong log, will fix.
Line 115:         (add_lvm_command, "::Storage.Misc.excCmd::(cmd)"),
Line 116:     ]
Line 117: 
Line 118:     stats = Stats()


Line 182: 
Line 183: def plot(stats, filename, size):
Line 184:     pyplot.figure(figsize=size, dpi=300)
Line 185: 
Line 186:     pyplot.subplot(311)
> what does 311 mean?  Maybe it should have a documented constant.
This is a "smart" shortcut for (row, column, num), I cleaned it up in a later patch.
Line 187:     pyplot.title("lastCheck")
Line 188:     pyplot.ylabel("lastCheck (seconds)")
Line 189:     pyplot.xlabel("time")
Line 190:     pyplot.grid(True)


-- 
To view, visit https://gerrit.ovirt.org/54080
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831e81dd6cb04607fc31579e45792d851fb45e29
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list