Change in vdsm[master]: bridge: usage of yaml schema
nsoffer at redhat.com
nsoffer at redhat.com
Thu Mar 3 19:31:16 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: bridge: usage of yaml schema
......................................................................
Patch Set 5:
(1 comment)
The verification code is complex and hard to verify :-) Lets add it in a separate patch.
Also there are no tests for the verification code, right? I don't think we can include complex code without tests in the critical path.
https://gerrit.ovirt.org/#/c/53919/5/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 111: self._report_inconsistency('Parameter %s is not %s type'
Line 112: % (name, t))
Line 113:
Line 114: def _report_inconsistency(self, message):
Line 115: if config.getboolean('devel', 'strick_mode'):
strick_mode -> strict_mode
Line 116: raise yajsonrpc.JsonRpcInvalidParamsError(message)
Line 117: else:
Line 118: self.log.warning(message)
Line 119:
--
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list