Change in vdsm[master]: restore-nets: move disable_ipv6 before setupNetworks, suppor...

danken at redhat.com danken at redhat.com
Tue Mar 1 18:32:27 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: restore-nets: move disable_ipv6 before setupNetworks, support bridgeless
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/54226/1/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 359: net_attrs.get('nic')
> Actually, nicless network are valid. Return None in this case.
Oops, bridged case is caught above.


-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list