Change in vdsm[master]: Hook: ide2sata: To switch IDE disks to SATA

fromani at redhat.com fromani at redhat.com
Wed Jan 27 14:12:15 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: Hook: ide2sata: To switch IDE disks to SATA
......................................................................


Patch Set 7:

Javier, thanks for the update. The testing you did looks ok, I just want to make sure the concern Nir raised is addressed.

We need to make sure that the translation this hook does is not confusing Engine, and that the added controller is handled OK.
This is especially important if we boot the VM with the hook enabled, and the we disable it. The VM must work fine afterwards.

Once that is verified, we could merge this.

-- 
To view, visit https://gerrit.ovirt.org/48450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0088dae191cf4560a00ee62023a54f5ab746a3c9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Javier Coscia <ciudavitacos at gmail.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Javier Coscia <ciudavitacos at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list