Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

shavivi at redhat.com shavivi at redhat.com
Wed Jan 27 14:11:08 UTC 2016


Shahar Havivi has posted comments on this change.

Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
......................................................................


Patch Set 13:

(4 comments)

https://gerrit.ovirt.org/#/c/49505/13/tests/fake-ssh-add
File tests/fake-ssh-add:

Line 20: 
Line 21: import getpass
Line 22: import sys
Line 23: 
Line 24: if len(sys.argv) > 1 and sys.argv[1] == '-D':
> if '-D' in sys.argv[1:]:
Done
Line 25:     print('All identities removed.')
Line 26: else:
Line 27:     print('Identity added: /home/%s/.ssh/id_rsa (/home/%s/.ssh/id_rsa)' %


https://gerrit.ovirt.org/#/c/49505/13/tests/fake-ssh-agent
File tests/fake-ssh-agent:

Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
Line 21: print('''SSH_AUTH_SOCK=/tmp/ssh-IWWQReDk7XZp/agent.31069; export SSH_AUTH_SOCK;
> does this need to be a constant?
I don't think so since the test is not opening the socket file.
Nir?
Line 22: SSH_AGENT_PID=31070; export SSH_AGENT_PID;


https://gerrit.ovirt.org/#/c/49505/13/vdsm/v2v.py
File vdsm/v2v.py:

Line 512: 
Line 513: 
Line 514: class XenCommand(V2VCommand):
Line 515:     '''
Line 516:     Importing Xen via virt-v2v reuqire to use xen+ssh protocol.
> typo: require
Done
Line 517:     this requires:
Line 518:     - enable the vdsm user in /etc/passwd
Line 519:     - generate ssh keys via ssh-keygen
Line 520:     - public key exchange with the imporing hosts user


Line 516:     Importing Xen via virt-v2v reuqire to use xen+ssh protocol.
Line 517:     this requires:
Line 518:     - enable the vdsm user in /etc/passwd
Line 519:     - generate ssh keys via ssh-keygen
Line 520:     - public key exchange with the imporing hosts user
> typo: importing
Done
Line 521:     - host must be in ~/.ssh/known_hosts (done automaticly
Line 522:       by ssh to the host before importing vm)
Line 523:     '''
Line 524:     def __init__(self, uri, vminfo, job_id, irs):


-- 
To view, visit https://gerrit.ovirt.org/49505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If544c0247003b6bc7189f72130553b9402dc915d
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list