Change in vdsm[master]: virt: move handling of recovery file in a class

danken at redhat.com danken at redhat.com
Tue Jan 19 11:50:29 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: virt: move handling of recovery file in a class
......................................................................


Patch Set 6:

(3 comments)

https://gerrit.ovirt.org/#/c/51388/6/vdsm/virt/recovery.py
File vdsm/virt/recovery.py:

Line 69: 
Line 70:     _log = logging.getLogger("virt.recovery.vmstate")
Line 71: 
Line 72:     def __init__(self, vmid):
Line 73:         self._vmid = vmid
unused
Line 74:         self._recovery_file = os.path.join(
Line 75:             constants.P_VDSM_RUN,
Line 76:             '%s.recovery' % vmid
Line 77:         )


Line 88: is not
placing the positive branch first is easier to understand.


https://gerrit.ovirt.org/#/c/51388/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 265: self.id = self.conf['vmId']
why are we initializing self.id so late?


-- 
To view, visit https://gerrit.ovirt.org/51388
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6866eb2c3c9d5784c2054c860cbf0977e8e58031
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list