Change in vdsm[master]: virt: move handling of recovery file in a class

fromani at redhat.com fromani at redhat.com
Tue Jan 19 11:48:40 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: move handling of recovery file in a class
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/51388/6/vdsm/virt/recovery.py
File vdsm/virt/recovery.py:

Line 61:     return [vm for vm, xmlDom in _listDomains()
Line 62:             if vmxml.has_channel(xmlDom, vmchannels.DEVICE_NAME)]
Line 63: 
Line 64: 
Line 65: class VmState(object):
s/VmState/File/g
?
Line 66:     """
Line 67:     "pickle" for vm state.
Line 68:     """
Line 69: 


Line 70:     _log = logging.getLogger("virt.recovery.vmstate")
Line 71: 
Line 72:     def __init__(self, vmid):
Line 73:         self._vmid = vmid
Line 74:         self._recovery_file = os.path.join(
self._path

?
Line 75:             constants.P_VDSM_RUN,
Line 76:             '%s.recovery' % vmid
Line 77:         )
Line 78:         self._lock = threading.Lock()


-- 
To view, visit https://gerrit.ovirt.org/51388
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6866eb2c3c9d5784c2054c860cbf0977e8e58031
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list