Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 13 21:11:42 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: lun: Serial attr should not passed to libvirt for lun disks.
......................................................................


Patch Set 3:

You broke the tests:

18:03:30 ======================================================================
18:03:30 FAIL: test_lun (vmStorageTests.DriveXMLTests)
18:03:30 ----------------------------------------------------------------------
18:03:30 Traceback (most recent call last):
18:03:30   File "/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/vmStorageTests.py", line 122, in test_lun
18:03:30     self.check({}, conf, xml, is_block_device=True)
18:03:30   File "/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/vmStorageTests.py", line 181, in check
18:03:30     self.assertXMLEqual(drive.getXML().toxml(), xml)
18:03:30   File "/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/testlib.py", line 242, in assertXMLEqual
18:03:30     (actualXML, expectedXML))
18:03:30 AssertionError: XMLs are different:
18:03:30 Actual:
18:03:30 <disk device="lun" sgio="unfiltered" snapshot="no" type="block">
18:03:30     <source dev="/dev/mapper/lun1" />
18:03:30     <target bus="scsi" dev="sda" />
18:03:30     <driver cache="none" error_policy="stop" io="native" name="qemu" type="raw" />
18:03:30 </disk>
18:03:30 
18:03:30 Expected:
18:03:30 <disk device="lun" sgio="unfiltered" snapshot="no" type="block">
18:03:30     <source dev="/dev/mapper/lun1" />
18:03:30     <target bus="scsi" dev="sda" />
18:03:30     <serial>54-a672-23e5b495a9ea</serial>
18:03:30     <driver cache="none" error_policy="stop" io="native" name="qemu" type="raw" />
18:03:30 </disk>

-- 
To view, visit https://gerrit.ovirt.org/51766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list