Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 13 20:53:56 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: lun: Serial attr should not passed to libvirt for lun disks.
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/51766/3//COMMIT_MSG
Commit Message:

Line 7: lun: Serial attr should not passed to libvirt for lun disks.
Line 8: 
Line 9: Following the change which was introduced at
Line 10: libvirt-1.2.17-5 and qemu-kvm-rhev-2.3.0-18, libvirt now enforce
Line 11: that a scsi-block 'lun' device should not provide the 'serial' property.
If this effects only scsi disks, we should avoid the serial only when using virtio-scsi, no?
Line 12: 
Line 13: To comply with this change, this patch introduces a change
Line 14: that a VM should ignore 'serial' property for lun devices when
Line 15: passing the XML to libvirt.


https://gerrit.ovirt.org/#/c/51766/3/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 363:             # floppies are used only internally for sysprep, so
Line 364:             # they are readonly unless explicitely stated otherwise
Line 365:             diskelem.appendChildWithArgs('readonly')
Line 366: 
Line 367:         if hasattr(self, 'serial') and (self.device != 'lun'):
Parenthesis unneeded.

Please update the tests with this logic.
Line 368:             diskelem.appendChildWithArgs('serial', text=self.serial)
Line 369: 
Line 370:         if hasattr(self, 'bootOrder'):
Line 371:             diskelem.appendChildWithArgs('boot', order=self.bootOrder)


-- 
To view, visit https://gerrit.ovirt.org/51766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list