Change in vdsm[master]: testlib: use arch from lib
nsoffer at redhat.com
nsoffer at redhat.com
Sat Jan 9 02:13:58 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: testlib: use arch from lib
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/49973/4/tests/testlib.py
File tests/testlib.py:
Line 165: _ARCH_REAL if _ARCH_REAL in (
Line 166: cpuarch.X86_64,
Line 167: cpuarch.PPC64,
Line 168: cpuarch.PPC64LE
Line 169: ) else _ARCH_FAKE
> good, but
I agree with Francesco, but we can go deeper, see my comment in latest version.
Line 170: )
Line 171:
Line 172:
Line 173: class VdsmTestCase(unittest.TestCase):
--
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I929b9258867377900fe161889465987ab44a6bc6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list