Change in vdsm[master]: testlib: use arch from lib

nsoffer at redhat.com nsoffer at redhat.com
Sat Jan 9 02:12:20 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: testlib: use arch from lib
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/49973/5/tests/testlib.py
File tests/testlib.py:

Line 1
Line 2
Update the copyright year


Line 50
Line 51
Line 52
Line 53
Line 54
This duplicates cpuarch code. We can drop both constants.


Line 165
Line 166
Line 167
Line 168
Line 169
Better:

    try:
        return cpuarch.real()
    except cpuarch.UnsupportedArchitecture:
        return cpuarch.X86_64


-- 
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I929b9258867377900fe161889465987ab44a6bc6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list