Change in vdsm[master]: tests: Improve object filtering tests

fromani at redhat.com fromani at redhat.com
Thu Jan 7 14:46:35 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: tests: Improve object filtering tests
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

Partial ack: looks fine,  but one question inside.

https://gerrit.ovirt.org/#/c/51038/4/tests/guestagentTests.py
File tests/guestagentTests.py:

Line 179:     ],
Line 180:     u'guestIPs': u'9.115.122.77 9.115.126.23 192.168.122.1'
Line 181: }
Line 182: """
Line 183:         elasped = timeit.timeit('_filterObject(d)', setup=setup, number=1000)
typo: elapsed - also in the line below
What this test measures? I mean is it supposed to fail if _filterObject() is too slow? Or it is just to provide feedback?
Line 184:         print(elasped, "seconds")
Line 185: 
Line 186: 
Line 187: class TestGuestIF(TestCaseBase):


-- 
To view, visit https://gerrit.ovirt.org/51038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17e4e1642c66218e96d3bb1059f6c3922dd531a3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list