Change in vdsm[master]: virt: Handle fork() related issues in vmchannels/guestagent
nsoffer at redhat.com
nsoffer at redhat.com
Thu Jan 7 14:37:12 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: virt: Handle fork() related issues in vmchannels/guestagent
......................................................................
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/42570/16/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:
Line 202
Line 203
Line 204
Line 205
Line 206
I hate staticmethods.
This should be instance method, or a module level function.
--
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer%redhat.com at gtempaccount.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list