Change in vdsm[master]: net: api: drop connectivity_check_networks

danken at redhat.com danken at redhat.com
Sat Feb 27 15:37:34 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: api: drop connectivity_check_networks
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

nit about the test

https://gerrit.ovirt.org/#/c/54070/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2471: nics[:2]
there are only to nics, stating nics[:2] seems redundant and confusing.


-- 
To view, visit https://gerrit.ovirt.org/54070
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bbfe2705c7165381a353d7d3effb493a1738631
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list