Change in vdsm[master]: net: api: drop connectivity_check_networks

phoracek at redhat.com phoracek at redhat.com
Fri Feb 26 22:05:15 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: net: api: drop connectivity_check_networks
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54070/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 693:     return int(options.get('connectivityTimeout',
Line 694:                            CONNECTIVITY_TIMEOUT_DEFAULT))
Line 695: 
Line 696: 
Line 697: def _check_connectivity(networks, bondings, options, logger):
> I think we should pass connectivityCheck and connectivityTimeout instead of
Good points! But I would definitely do that in another patch - I'm lazy, it feels right to have it in a separate patch and I'd like to have this merged together with the module split ASAP.
Line 698:     if utils.tobool(options.get('connectivityCheck', True)):
Line 699:         logger.debug('Checking connectivity...')
Line 700:         if not _clientSeen(_get_connectivity_timeout(options)):
Line 701:             logger.info('Connectivity check failed, rolling back')


-- 
To view, visit https://gerrit.ovirt.org/54070
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bbfe2705c7165381a353d7d3effb493a1738631
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list