Change in vdsm[master]: tests: add tests for vmstats.cpu()

fromani at redhat.com fromani at redhat.com
Tue Feb 23 07:56:50 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: tests: add tests for vmstats.cpu()
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/53777/3/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:

Line 96: 
Line 97:     stats['ioTune'] = io_tune_info
Line 98: 
Line 99: 
Line 100: def cpu(stats, first_sample, last_sample, interval):
> Could you document the crazy return value?
empty dict was my mistake, added that return value for testing purposes only. Should be 'return None' in that case
Line 101:     stats['cpuUser'] = 0.0
Line 102:     stats['cpuSys'] = 0.0
Line 103: 
Line 104:     if first_sample is None or last_sample is None:


-- 
To view, visit https://gerrit.ovirt.org/53777
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d8fe466a351335922f31b7ae264d2a870a30edb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list