Change in vdsm[master]: tests: add tests for vmstats.cpu()

danken at redhat.com danken at redhat.com
Tue Feb 23 06:22:22 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: tests: add tests for vmstats.cpu()
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/53777/3//COMMIT_MSG
Commit Message:

Line 7: tests: add tests for vmstats.cpu()
Line 8: 
Line 9: Add tests for vmstats.cpu().
Line 10: The reference data was take either by libvirt (virsh -r domstats)
Line 11: or from a log-enhanced running Vdsm.
taken
Line 12: 
Line 13: Change-Id: I8d8fe466a351335922f31b7ae264d2a870a30edb


https://gerrit.ovirt.org/#/c/53777/3/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:

Line 96: 
Line 97:     stats['ioTune'] = io_tune_info
Line 98: 
Line 99: 
Line 100: def cpu(stats, first_sample, last_sample, interval):
Could you document the crazy return value?
(None, empty dict, default dict with zeros, real data)
And make sure you test them all.
Line 101:     stats['cpuUser'] = 0.0
Line 102:     stats['cpuSys'] = 0.0
Line 103: 
Line 104:     if first_sample is None or last_sample is None:


-- 
To view, visit https://gerrit.ovirt.org/53777
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d8fe466a351335922f31b7ae264d2a870a30edb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list