Change in vdsm[master]: vm: destroy: try harder destroying a Vm

fromani at redhat.com fromani at redhat.com
Mon Feb 22 10:42:54 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: vm: destroy: try harder destroying a Vm
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53747/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3832: 
Line 3833:         return response.success()
Line 3834: 
Line 3835:     def _destroyVm(self):
Line 3836:         res = self._destroyVmGraceful()
> Clearly, there are some errors that do not merit another attempt (e.g. no d
Ok, fully makes sense to me.
Hence, question to make sure I fully got it:
this basically means that we should keep a list of libvirt error codes, and this ultimately means we should play catch-up. Is my understanding right?

If this is what we want, I'll just abandon this patch and post a new one-liner to add another error code in line 3847 (old code).
Line 3837:         if response.is_error(res):
Line 3838:             res = self._destroyVmForceful()
Line 3839:         return res
Line 3840: 


-- 
To view, visit https://gerrit.ovirt.org/53747
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6519bf45565ffb879781926f437811a9bf5302b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list