Change in vdsm[master]: vm: destroy: try harder destroying a Vm
danken at redhat.com
danken at redhat.com
Sat Feb 20 10:11:28 UTC 2016
Dan Kenigsberg has posted comments on this change.
Change subject: vm: destroy: try harder destroying a Vm
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
I prefer being more prudent and killing the VM only after we are sure we asked it to save its data.
https://gerrit.ovirt.org/#/c/53747/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3832:
Line 3833: return response.success()
Line 3834:
Line 3835: def _destroyVm(self):
Line 3836: res = self._destroyVmGraceful()
Clearly, there are some errors that do not merit another attempt (e.g. no domain, connection broken, some crazy internal libvirt error).
I don't remember the details, but I think we've been warned against zapping guest data on any libvirt error. https://bugzilla.redhat.com/show_bug.cgi?id=795656
Line 3837: if response.is_error(res):
Line 3838: res = self._destroyVmForceful()
Line 3839: return res
Line 3840:
--
To view, visit https://gerrit.ovirt.org/53747
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6519bf45565ffb879781926f437811a9bf5302b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list