Change in vdsm[master]: tests: Move network tests to its own folder

edwardh at redhat.com edwardh at redhat.com
Sun Feb 21 12:43:28 UTC 2016


Edward Haas has posted comments on this change.

Change subject: tests: Move network tests to its own folder
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/53704/1/tests/network/__init__.py
File tests/network/__init__.py:

Line 1: #
Line 2: # Copyright 2013 Red Hat, Inc.
> This convention collides with other such files in the project.
Talked to Dan and it seems to be a nit.

As it requires special treatment for the absolute_import validation (see below comment), I propose to leave it like this and if you have strong opinion about it, remove it in a following patch.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: from __future__ import absolute_import
> We don't have any imports, so this import is not needed.
Any *.py file is checked for the existence of this line.
(we could add logic so empty files won't be examined, but that is out of scope).


https://gerrit.ovirt.org/#/c/53704/1/tests/network/net_info_test.py
File tests/network/net_info_test.py:

> I was not sure what the format should be, waiting for votes on this.
Done
Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify


-- 
To view, visit https://gerrit.ovirt.org/53704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35031fd50d0451c6321bdf8eee28127422bedafe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list