Change in vdsm[master]: tests: Move network tests to its own folder

edwardh at redhat.com edwardh at redhat.com
Sat Feb 20 23:24:35 UTC 2016


Edward Haas has posted comments on this change.

Change subject: tests: Move network tests to its own folder
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/53704/1/tests/Makefile.am
File tests/Makefile.am:

Line 83: 	monkeypatchTests.py \
Line 84: 	momTests.py \
Line 85: 	momPolicyTests.py \
Line 86: 	mountTests.py \
Line 87: 	network/*_test.py \
> You should have a Makefile in network, this is how vdsm build system works.
I added it there now for the build/install, but it is still needed here in order for all the tests to run in one test run.
Line 88: 	numaUtilsTests.py \
Line 89: 	outOfProcessTests.py \
Line 90: 	parted_utils_tests.py \
Line 91: 	passwordsTests.py \


https://gerrit.ovirt.org/#/c/53704/1/tests/network/__init__.py
File tests/network/__init__.py:

Line 1: #
Line 2: # Copyright 2013 Red Hat, Inc.
> Please keep this as empty file.
This convention collides with other such files in the project.
Keeping such __init__ files empty is the right convention?
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


https://gerrit.ovirt.org/#/c/53704/1/tests/network/net_info_test.py
File tests/network/net_info_test.py:

> Can you explain the net_ prefix? Why is this needed when we have a package 
I was not sure what the format should be, waiting for votes on this.
I'm ok with removing the net prefix.
Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify


-- 
To view, visit https://gerrit.ovirt.org/53704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35031fd50d0451c6321bdf8eee28127422bedafe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list