Change in vdsm[master]: virt: Make Vm.devSpecMapFromConf() private

fromani at redhat.com fromani at redhat.com
Thu Feb 18 10:30:20 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Make Vm.devSpecMapFromConf() private
......................................................................


Patch Set 3: Code-Review+1

I see nothing wrong here. Partial ACK.

Note to self/thinking aloud:
I don't really like the direction on which we use private attributes in test code. We do it already, so we should start to change direction. But after this patch series lands :)

-- 
To view, visit https://gerrit.ovirt.org/53483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dffb82bde715453ff4ae3eae3b82b4890f04f8b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list