Change in vdsm[master]: virt: Don't use Vm device configuration in clientIF

fromani at redhat.com fromani at redhat.com
Thu Feb 18 10:28:17 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Don't use Vm device configuration in clientIF
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

good idea, possible improvement inside. Partial ACK.

https://gerrit.ovirt.org/#/c/53482/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 748:         if drives is None:
        :             drives = self.devSpecMapFromConf()[hwclass.DISK]
this is a good idea, but we could do another step further.

preparePaths() it is always invoked with the Vm's drives, here in vm.py or in clientIF.

Actually, it doesn't make sense to call it otherwise.
So, let's just drop the `drives' argument, and let's make this method fetch the drive list:

  def preparePaths(self):
    drives = self.devSpecMapFromConf()[hwclass.DISK]

should we need some device filtering (e.g. DO NOT prepare paths for some drives, for whatever reason), we'll handle this in a future patch. I don't think we'll need this, however.


-- 
To view, visit https://gerrit.ovirt.org/53482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd0f7c99b4df18d27dfad36bf2275540bc8b958c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list