Change in vdsm[master]: migration: added support for setting the convergenceSchedule

fromani at redhat.com fromani at redhat.com
Wed Feb 17 15:54:24 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: added support for setting the convergenceSchedule
......................................................................


Patch Set 15:

(3 comments)

https://gerrit.ovirt.org/#/c/47734/15/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 7798: alias
> This is how I have started, but the 'type' expects "name: arg" format so th
Makes sense, but not sure this is the best approach. Will dig a bit more


Line 7815: # List of actions which will be executed before migration starts and list
         : # of actions which will be executed as a reaction to stalling.
> hmmm, it could but not sure if it would make this better or worse...
This could make sense if we go in the `type' direction. If we keep this as alias, I concur this will not help.


Line 7887: #optional actions to perform when stalling
         : #                       The format is a JSON, which consists of two lists:
         : #                       [init, convergence]
         : #                       The init is a list of: [action, [params]]
         : #                       The convergence is a list of:
         : #                       [stalling limit, [action, [params]]]
> - removed the details from here.
Interesting, How it failed?


-- 
To view, visit https://gerrit.ovirt.org/47734
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09818e6f3283880edb704cb77c1f716392b11abe
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list