Change in vdsm[master]: net: api: remove bonding handling from _addNetwork
edwardh at redhat.com
edwardh at redhat.com
Wed Feb 17 15:43:43 UTC 2016
Edward Haas has posted comments on this change.
Change subject: net: api: remove bonding handling from _addNetwork
......................................................................
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53475/11/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 434: bridged and not keep_bridge, _netinfo)
Line 435:
Line 436: net_ent = _objectivizeNetwork(bridge=network if bridged else None,
Line 437: vlan=vlan, vlan_id=vlan_id, bonding=bonding,
Line 438: nic=nics[0] if nics and not bonding
> it's not needed, but it make more sense IMO. objectivizeNetwork() expects n
If only one is valid, why do we pass both in the first place?
What about this: ?
Replace both bonding & nic with iface, checking if bond or not inside.
Dan will probably prefer it in a separated patch.
Line 439: else None,
Line 440: _netinfo=_netinfo,
Line 441: configurator=configurator,
Line 442: implicitBonding=implicitBonding)
--
To view, visit https://gerrit.ovirt.org/53475
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20c79bc8e3d8a0db5e814ad91fa9fcf8ca71be04
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list