Change in vdsm[master]: tests: import missing module in functional/utils

mpolednik at redhat.com mpolednik at redhat.com
Mon Feb 15 15:02:29 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: tests: import missing module in functional/utils
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/53529/1/tests/functional/utils.py
File tests/functional/utils.py:

Line 28: from vdsm import ipwrapper
Line 29: from vdsm import vdscli
Line 30: from vdsm import jsonrpcvdscli
Line 31: from vdsm import netinfo
Line 32: from vdsm.netinfo import cache
> Not clear why this is needed.
Right, but netinfo does not expose cache.


>>> from vdsm import netinfo
>>> dir(netinfo)
['DUMMY_BRIDGE', 'LIBVIRT_NET_PREFIX', 'NET_PATH', '__builtins__', '__doc__', '__file__', '__name__', '__package__', '__path__', 'absolute_import', 'etree', 'libvirtconnection', 'networks']
>>> netinfo.cache
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute 'cache'
>>> from vdsm.netinfo import cache
>>> cache
<module 'vdsm.netinfo.cache' from '/usr/lib/python2.7/site-packages/vdsm/netinfo/cache.pyc'>
Line 33: from vdsm import supervdsm
Line 34: from vdsm.netconfpersistence import RunningConfig
Line 35: 
Line 36: 


-- 
To view, visit https://gerrit.ovirt.org/53529
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefce053c06527e0745e22c3bd0d9cfd3a0a7084a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list