Change in vdsm[master]: tests: import missing module in functional/utils

edwardh at redhat.com edwardh at redhat.com
Mon Feb 15 14:54:31 UTC 2016


Edward Haas has posted comments on this change.

Change subject: tests: import missing module in functional/utils
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/53529/1/tests/functional/utils.py
File tests/functional/utils.py:

Line 28: from vdsm import ipwrapper
Line 29: from vdsm import vdscli
Line 30: from vdsm import jsonrpcvdscli
Line 31: from vdsm import netinfo
Line 32: from vdsm.netinfo import cache
Not clear why this is needed.
The only reference to cache is at _get_netinfo() which calls it through netinfo (netinfo.cache)
Line 33: from vdsm import supervdsm
Line 34: from vdsm.netconfpersistence import RunningConfig
Line 35: 
Line 36: 


-- 
To view, visit https://gerrit.ovirt.org/53529
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefce053c06527e0745e22c3bd0d9cfd3a0a7084a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list