Change in vdsm[master]: jsonrpcvdscli: Arrays can be returned from client call
mlibra at redhat.com
mlibra at redhat.com
Sat Feb 13 12:50:26 UTC 2016
Marek Libra has posted comments on this change.
Change subject: jsonrpcvdscli: Arrays can be returned from client call
......................................................................
Patch Set 1:
> (1 comment)
>
> AFAIU the idea is fine, but looking at the surrounding code it
> seems we are start adding too many special cases (and if branches).
>
> Hence, please look at the inline comment; we need a bit more
> context.
>
> -1 for visibility purposes, actually I quite like this patch.
Before this patch, call like:
service = jsonrpcvdscli.connect(rqueue)
service.getAllVmStats()
fails with:
File "/usr/lib/python2.7/site-packages/vdsm/jsonrpcvdscli.py", line 118, in _callMethod
return response.success(**resp.result)
TypeError: success() argument after ** must be a mapping, not list
since the getAllVmStats() returns an array instead of expected dict.
--
To view, visit https://gerrit.ovirt.org/53452
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff22f6d75e9ff3400d1a2a2f64de5c121192e2f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No
More information about the vdsm-patches
mailing list