Change in vdsm[master]: jsonrpcvdscli: Arrays can be returned from client call

fromani at redhat.com fromani at redhat.com
Fri Feb 12 16:19:44 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: jsonrpcvdscli: Arrays can be returned from client call
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

AFAIU the idea is fine, but looking at the surrounding code it seems we are start adding too many special cases (and if branches).

Hence, please look at the inline comment; we need a bit more context.

-1 for visibility purposes, actually I quite like this patch.

https://gerrit.ovirt.org/#/c/53452/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Only a dict response was expected from client method call
Line 10: in jsonrpcvdscli before this patch.
Line 11: With this patch, the non-dict (i.e. arrays) responses are wraped
Line 12: in a dict 'items', so calls like getAllVmStats will not fail.
could you please add an example of how it failed before this patch?
Line 13: 
Line 14: Change-Id: Iff22f6d75e9ff3400d1a2a2f64de5c121192e2f2


-- 
To view, visit https://gerrit.ovirt.org/53452
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff22f6d75e9ff3400d1a2a2f64de5c121192e2f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list