Change in vdsm[master]: Dynamic load of supervdsm_api funcs

danken at redhat.com danken at redhat.com
Thu Feb 11 08:45:49 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: Dynamic load of supervdsm_api funcs
......................................................................


Patch Set 14: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/52875/14/vdsm.spec.in
File vdsm.spec.in:

Line 1248: %{_datadir}/%{vdsm_name}/tests/glusterVolumeTasks.xml
Line 1249: %{_datadir}/%{vdsm_name}/tests/functional/*.py*
Line 1250: %{_datadir}/%{vdsm_name}/tests/functional/*.policy
Line 1251: %{_datadir}/%{vdsm_name}/tests/integration/*.py*
Line 1252: %{_datadir}/%{vdsm_name}/supervdsm_api/test_api.py*
alphabetic order
Line 1253: 
Line 1254: %files hook-openstacknet
Line 1255: %defattr(-, root, root, -)
Line 1256: %{_sysconfdir}/sudoers.d/50_vdsm_hook_openstacknet


https://gerrit.ovirt.org/#/c/52875/14/vdsm/supervdsm_api/network.py
File vdsm/supervdsm_api/network.py:

Line 28: # Ignoring pyflakes unused import warning
this comment is no redundant


Line 27: 
Line 28: # Ignoring pyflakes unused import warning
Line 29: expose(restoreNetworks)
Line 30: expose(setupNetworks)
Line 31: expose(setSafeNetworkConfig)
> The trivial option is to have a bridge here (define a func that calls resto
+1 for the trivial solution

@expose
def restoreNetworks(*args, **kwrags):
  return restore(*args, **kwrags)


-- 
To view, visit https://gerrit.ovirt.org/52875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67a1c349c15a03ba54788ffafd0c5b9d30ff7037
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list