Change in vdsm[master]: migration: added support for setting the convergenceSchedule

fromani at redhat.com fromani at redhat.com
Thu Feb 11 08:43:25 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: added support for setting the convergenceSchedule
......................................................................


Patch Set 14: Code-Review+2

(1 comment)

without stricter format description in the schema, or even JSON support (none of them are in sight) I think this is good enough.

https://gerrit.ovirt.org/#/c/47734/14//COMMIT_MSG
Commit Message:

Line 16: 	[
       : 		["initActionWith2Params", [param1, param2]],
       : 		["initActionWithoutParams", []]
       : 	],
       : 	[
       : 		[stallingLimit1, ["actionWithParams",[param1, param2]]],
       : 		[stallingLimit2, ["actionWithoutParams",[]]]
       : 	]
Surprisingly to me, it seems we already have tabs in commit messages, so I guess these are OK too :)


-- 
To view, visit https://gerrit.ovirt.org/47734
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09818e6f3283880edb704cb77c1f716392b11abe
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list