Change in vdsm[master]: monitor: Add udev monitor

rmohr at redhat.com rmohr at redhat.com
Thu Feb 11 08:35:08 UTC 2016


Roman Mohr has posted comments on this change.

Change subject: monitor: Add udev monitor
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/47729/9/lib/vdsm/udev/monitor.py
File lib/vdsm/udev/monitor.py:

Line 98:             self._monitor.filter_by(subsystem, device_type)
Line 99:             callbacks = self._subscriptions.get((subsystem, device_type), [])
Line 100:             callbacks.append(callback)
Line 101:             self._subscriptions[(subsystem, device_type)] = callbacks
Line 102:             self._start_if_necessary()
> Not fan of this approach. Something more explicit would be nicer - for exam
Just to make this clear, adding a subscription only starts the monitor if start() was called before and no subscription was present at that time.
Line 103: 
Line 104:     def start(self):
Line 105:         self._can_start = True
Line 106:         with self._filter_lock:


-- 
To view, visit https://gerrit.ovirt.org/47729
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b91753424d83896fa538eb6b57f8653b6332fbb
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list