Change in vdsm[master]: hsm: Remove image run links in teardownImage

laravot at redhat.com laravot at redhat.com
Thu Feb 11 08:30:12 UTC 2016


Liron Aravot has posted comments on this change.

Change subject: hsm: Remove image run links in teardownImage
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/53298/2/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

Line 1119: 
Line 1120:         If the image is based on a template image it should be expressly
Line 1121:         deactivated.
Line 1122:         """
Line 1123:         self.removeImageLinks(imgUUID)
> when activating we create the links as the last operation, dont we prefer t
i'm not sure if its preferred, because that way we have a stale link till the deactivation (link removal) is complete, on the other hand..if the lvs deactivation fails for some reason we remain without the link.
Line 1124:         allVols = self.getAllVolumes()
Line 1125:         volUUIDs = self._manifest._getImgExclusiveVols(imgUUID, allVols)
Line 1126:         lvm.deactivateLVs(self.sdUUID, volUUIDs)
Line 1127: 


-- 
To view, visit https://gerrit.ovirt.org/53298
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4568aaac2ce26c67132a839d95b75dd97bb28f29
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list