Change in vdsm[master]: net: api: drop 'add' 'del' 'edit' cli args

danken at redhat.com danken at redhat.com
Wed Feb 10 11:38:16 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: api: drop 'add' 'del' 'edit' cli args
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/53299/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 976: def _parseKwargs(args):
Line 977:     return dict(arg.split('=', 1) for arg in args)
Line 978: 
Line 979: 
Line 980: def main():
> +1
Petr, that is what I meant. I give up my attempt to "protect" this currently unused code. If we break networking apart of the rest of Vdsm, we would re-write it.
Line 981:     if len(sys.argv) <= 1:
Line 982:         usage()
Line 983:         raise ConfigNetworkError(ne.ERR_BAD_PARAMS, "No action specified")
Line 984:     if sys.argv[1] == 'list':


-- 
To view, visit https://gerrit.ovirt.org/53299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I430977e5137fcdef546fae7a3bac26f46668c7ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list