Change in vdsm[master]: net: drop isolatedCommand handling
phoracek at redhat.com
phoracek at redhat.com
Wed Feb 10 11:19:16 UTC 2016
Petr Horáček has posted comments on this change.
Change subject: net: drop isolatedCommand handling
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/51281/4/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 226: ipaddr=None, netmask=None, prefix=None, mtu=None, gateway=None,
Line 227: dhcpv6=None, ipv6addr=None, ipv6gateway=None,
Line 228: ipv6autoconf=None, bondingOptions=None, bridged=True,
Line 229: _netinfo=None, hostQos=None, defaultRoute=None,
Line 230: blockingdhcp=False, **options):
> Maybe from _addNetworkWithExc (test)
Do you think I should keep optional configurator=None argument, change testAddNetworkValidation(test) into testSetupNetworkValidation() or get 'configurator' in the test?
Line 231: nics = nics or ()
Line 232: if _netinfo is None:
Line 233: _netinfo = CachingNetInfo()
Line 234: if dhcpv6 is not None:
--
To view, visit https://gerrit.ovirt.org/51281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad10ec7013b280d78f60703d741e72334358f39
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list