Change in vdsm[master]: virt: migration: initialize SourceThread._destServer on __in...

danken at redhat.com danken at redhat.com
Sun Feb 7 15:56:12 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: migration: initialize SourceThread._destServer on __init__
......................................................................


virt: migration: initialize SourceThread._destServer on __init__

Introducing data members during runtime is a bad practice. In this case,
it caused a noisy log distraction when the destination host name could
not be resolved.

This patch initializes _destServer to None, and makes sure it has a
valid value before using it.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1299886
Change-Id: Ie773d7eadbacd1eac6e0929d5f264a5c2d4f6a57
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/52897
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-by: Martin Polednik <mpolednik at redhat.com>
---
M vdsm/virt/migration.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Anonymous Coward #1001177: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Martin Polednik: Looks good to me, but someone else must approve
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/52897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie773d7eadbacd1eac6e0929d5f264a5c2d4f6a57
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Anonymous Coward #1001177
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list