Change in vdsm[master]: network: don't log missing brif files

edwardh at redhat.com edwardh at redhat.com
Sun Feb 7 15:44:21 UTC 2016


Edward Haas has posted comments on this change.

Change subject: network: don't log missing brif files
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/53095/2/lib/vdsm/netinfo/bridges.py
File lib/vdsm/netinfo/bridges.py:

Line 37:     else:
Line 38:         # to not leave noise in supervdsm.log, don't log invalid attempts to
Line 39:         # obtain bridge's brif file. that could happen when bridge is a part
Line 40:         # of OVS.
Line 41:         logging.warning('Failed to obtain brif file %s' % brif_path)
I don't see why this is better than a trace, both do not describe well the issue.
Line 42:         bridge_ports = []
Line 43:     return bridge_ports
Line 44: 
Line 45: 


-- 
To view, visit https://gerrit.ovirt.org/53095
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e9feb565b69f097aeb2d2725e2f668cf43fea8b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list