Change in vdsm[master]: net: IP DHCP detection

danken at redhat.com danken at redhat.com
Fri Feb 5 20:10:21 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: IP DHCP detection
......................................................................


net: IP DHCP detection

Improve and fix DHCP status detection.

There have been several points covered in this patch:
- dhcpv6 is now correctly detected (directly from kernel).
- dhcp detection simplified by checking ip interface flags (through
  netlink). This method is also faster and reduces complexity.
- Code cleanup.

Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Signed-off-by: Edward Haas <edwardh at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53076
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netinfo/addresses.py
M lib/vdsm/netinfo/cache.py
M lib/vdsm/netinfo/dhcp.py
M lib/vdsm/netlink/addr.py
M tests/functional/networkTests.py
M tests/netinfoTests.py
M vdsm_hooks/ovs/ovs_after_get_caps.py
7 files changed, 72 insertions(+), 225 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list