Change in vdsm[master]: net: IP DHCP detection

danken at redhat.com danken at redhat.com
Fri Feb 5 20:10:16 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: IP DHCP detection
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/53076/6/lib/vdsm/netinfo/addresses.py
File lib/vdsm/netinfo/addresses.py:

Line 120: def is_ipv6(nladdr):
Line 121:     return nladdr['family'] == 'inet6'
Line 122: 
Line 123: 
Line 124: def is_dynamic(nladdr):
I think it is pointless to introduce another name. But let us go your way this time.


-- 
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0396610822e3a41d44f37346ee1aad71d569d1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list