Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

danken at redhat.com danken at redhat.com
Mon Feb 1 19:35:44 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
......................................................................


Patch Set 15: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/49505/15/vdsm/v2v.py
File vdsm/v2v.py:

Line 289: '''
nit: we use triple double quotes (""") for doctext


Line 309: ''.join(out))
if you don't want execCmd to split by newlines, pass raw=True. yes, it's a crazy semantics.


Line 320: rc != 0:
unless ssh-add complained that there is no agent, we should  kill the agent, shouldn't we?


-- 
To view, visit https://gerrit.ovirt.org/49505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If544c0247003b6bc7189f72130553b9402dc915d
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list