Change in vdsm[master]: Hook: ide2sata: To switch IDE disks to SATA

ciudavitacos at gmail.com ciudavitacos at gmail.com
Mon Feb 1 19:31:10 UTC 2016


Javier Coscia has posted comments on this change.

Change subject: Hook: ide2sata: To switch IDE disks to SATA
......................................................................


Patch Set 7:

Francesco and the rest of the team, sorry for the delay, I found an issue with the hook while using 3 IDE disks. I did the tests with 2 and worked fine, the problem comes when you set 3 disks. I'm currently working on a fix for this but before I continue I'd like to ask if it's ok/allowed to modify the DB after the VM gets powered off, the reason I'm asking is because when you shutdown the VM, the vm_device table will contain the 'address' for the third device as "{bus=0, controller=0, type=drive, target=0, unit=2}" (this is part of the fix) and this will prevent the VM to start when the hook is off or even not configured because an IDE bus cannot contain more then 2 units (0 and 1), I need to change that to be "{bus=1, controller=0, type=drive, target=0, unit=1}" to avoid that issue and also the device duplication, so basically I'm working on a 'after_vm_destroy' script which connects to the 'engine' DB and modifies that, but before I continue I'd like to know if this will !
 be an accepted approach or not. Thanks!!

-- 
To view, visit https://gerrit.ovirt.org/48450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0088dae191cf4560a00ee62023a54f5ab746a3c9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Javier Coscia <ciudavitacos at gmail.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Javier Coscia <ciudavitacos at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list