Change in vdsm[master]: Make VM._correctGraphicsConfiguration use DomainDescriptor
mzamazal at redhat.com
mzamazal at redhat.com
Mon Feb 1 16:04:33 UTC 2016
Milan Zamazal has posted comments on this change.
Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:
Line 68:
Line 69: def __init__(self, xmlStr):
Line 70: super(DomainDescriptor, self).__init__(xmlStr)
Line 71: self._xml = xmlStr
Line 72: self._devices = super(DomainDescriptor, self).devices
> You are right, I missed the "just once" part.
> It could be worth to make the class names more explicit when this is un-drafted.
Definitely, but I couldn't find good names, hoping reviewers won't like these ones and will suggest something better. ;-)
Line 73: self._devices_hash = super(DomainDescriptor, self).devices_hash
Line 74:
Line 75: @property
Line 76: def xml(self):
--
To view, visit https://gerrit.ovirt.org/52823
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9583d81d3d561d806499b55aa64f733437800c4b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list