Change in vdsm[master]: periodic: ignore known-benign libvirt errors

fromani at redhat.com fromani at redhat.com
Mon Feb 1 16:03:22 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: periodic: ignore known-benign libvirt errors
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/52884/4/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:

Line 294:             self._vm.log.warning('could not run on %s: domain not connected',
Line 295:                                  self._vm.id)
Line 296:         except libvirt.libvirtError as e:
Line 297:             if e.get_error_code() in (libvirt.VIR_ERR_NO_DOMAIN,
Line 298:                                       libvirt.VIR_ERR_OPERATION_UNSUPPORTED,):
> It's not clear to me why libvirt.VIR_ERR_OPERATION_UNSUPPORTED is included 
Good point. Will add a comment here.
Line 299:                 # known benign cases: migration in progress or completed
Line 300:                 if migrating or self._vm.lastStatus == vmstatus.DOWN:
Line 301:                     return
Line 302:             raise


-- 
To view, visit https://gerrit.ovirt.org/52884
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5618f44870bdca97fa479734514a3c8d81c7d7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list