Change in vdsm[master]: monitoring: Introduce the asyncevent module

fromani at redhat.com fromani at redhat.com
Wed Apr 27 12:15:07 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
......................................................................


Patch Set 18: Code-Review+1

(3 comments)

very nice patch and sensible approach, keeping one eye on python3 (and borrowing code :)) is the right thing to do.
Conditional ACK: if we -projectwise- we want another better event loop, this seems a very good step forward.
I'm inclined to think fixing current code is not a better approach, for once.

https://gerrit.ovirt.org/#/c/54849/16/lib/vdsm/storage/asyncevent.py
File lib/vdsm/storage/asyncevent.py:

PS16, Line 305: vdsmm
typo: Vdsm


https://gerrit.ovirt.org/#/c/54849/18/lib/vdsm/storage/asyncevent.py
File lib/vdsm/storage/asyncevent.py:

PS18, Line 342: _cancelled
this is private because it was so in python3, right?
Otherwise I think it should be public.


PS18, Line 413:     The read end of the pipe is watched by the event loop, while other threads
              :     may wakeup the event loop by writing a byte to the write end.
              : 
              :     Based on twisted.internet.posixbase._UnixWaker.
question: did you considered eventfd? If it was discarded, could you provide the rationale (for documentation purposes)?


-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list